This repository was archived by the owner on Jul 12, 2020. It is now read-only.
[File] Fix relative paths calculation for mixed slash paths #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getRelativePath [FileTest] fix file paths for input of the psr0 class test
beberlei
added a commit
that referenced
this pull request
Oct 25, 2013
[File] Fix relative paths calculation for mixed slash paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, hopefully the last pull request for windows-tests issues.
When paths were added from the directory with the recursive directory iterators there were some mixed paths constructed like:
vfs://project/src/Foo\Bar.php. They were not converted, so the diff-tests (behat) fail.I fixed this edge case.
second: I noticed that the psr-0-classname test did not work on windows with unix paths.
and third: the master tests do fail right now, thats why this pull request fails, too.
Sorry, could not figure it out